Pre-compile regex patterns in match functions#1691
Open
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
…ment Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Change all regex in match functions to pre-compiled
Pre-compile regex patterns in match functions
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegexMatchwas compiling regex patterns on every call viaregexp.MatchString, causing repeated allocations and compilation overhead.Changes
Changed
RegexMatchto use the existingmustCompileOrGetcaching mechanism:Impact
sync.RWMutexin cacheKeyMatch2,KeyMatch3,KeyMatch5(all callRegexMatch)Added benchmarks to verify performance improvement.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.